Pete Bacon Darwin
cd29f6130d
docs: remove VS 2015 guide ( #42253 )
...
This guide is outdated and doesn't appear in the navigation.
Fixes #17320
PR Close #42253
2021-05-25 22:14:03 +00:00
Alan Agius
9402bf0667
ci: add myself to fw-platform-server reviewers ( #42265 )
...
Add `alan-agius4` as `platform-server` reviewer.
PR Close #42265
2021-05-24 18:16:51 +00:00
David Shevitz
58be6d7b95
docs: add new tutorial that explains how to use the UrlMatcher for custom route matching ( #42138 )
...
PR Close #42138
2021-05-20 23:05:32 +00:00
Joey Perrott
6ffa0602d1
ci: add Teri to global approvers for docs changes list ( #42200 )
...
Note Teri's addition to the global approvers list for docs changes for pullapprove.
PR Close #42200
2021-05-20 23:03:50 +00:00
Joey Perrott
03ed304610
ci: add alex to global approvers list ( #42200 )
...
Note alex's addition to the global approvers list for pullapprove.
PR Close #42200
2021-05-20 23:03:50 +00:00
Joey Perrott
38ed5f79cd
ci: remove misko from pullapprove code ownership ( #42200 )
...
Remove misko from pullapprove to remove his code review assignment.
PR Close #42200
2021-05-20 23:03:50 +00:00
Joey Perrott
2d15b3357c
build: reformat yml files ( #42179 )
...
Reformat all yml files in the repository
PR Close #42179
2021-05-19 11:55:13 -07:00
mgechev
e141aa5544
ci: rename the angular devtools pullapprove name ( #42160 )
...
Change `devtools` to `docs-devtools` to properly reflect the approval
group.
PR Close #42160
2021-05-19 10:04:48 -07:00
David Shevitz
c7fe799ef9
docs: move all existing router documentation into a single location and add two new topics: an overview and a reference ( #41972 )
...
PR Close #41972
2021-05-18 15:39:39 -07:00
mgechev
c58e15a4b0
ci: add pullapprove entries for devtools ( #42152 )
...
Add twerske and mgechev as approvals for the Angular DevTools docs to
pullapprove.
PR Close #42152
2021-05-18 11:18:36 -07:00
Kapunahele Wong
e56cb5fc9f
docs: add redirect and update updating-to-v11 to v12 ( #41625 )
...
PR Close #41625
2021-05-06 15:15:09 -04:00
David Shevitz
df2ff0497d
docs: initial commit of content projection topic. ( #41143 )
...
Content projection is an important part of Angular. However, it has
never been documented in the Angular documentation set. This topic
attempts to provide the basics of content projection for developers. It
is not a comprehensive guide; rather, it is a starting point that we
can hopefully expand upon in the future.
PR Close #41143
2021-05-05 13:47:27 -07:00
David Shevitz
2d9bfdf842
docs: add new migration guide to v12 documentation that describes how to migrate older localization ids to new ones ( #41828 )
...
PR Close #41828
2021-05-04 08:09:52 -07:00
Andrew Kushnir
c7b40ba15a
ci: changes to packages/common/http should not require fw-common approval ( #41887 )
...
Currently when the change is made to the code inside the `packages/common/http` folder, both `fw-http` and `fw-common` group members are assigned for review. However only `fw-http` is required and should be sufficient. This commit updates the PullApprove config to exclude `packages/common/http` path from the list of folders that `fw-common` "owns".
PR Close #41887
2021-04-29 13:49:39 -07:00
Zach Arend
0e09009f7d
ci: add Zach Arend to pullapprove groups ( #41839 )
...
Add Zach Arend to the pullapprove groups for public api, size tracking,
and circular deps.
PR Close #41839
2021-04-27 11:35:06 -07:00
Zach Arend
3c586fa4e0
ci: add Zach Arend to pullapprove ( #41386 )
...
add Zach Arend to .pullapprove.yml
PR Close #41386
2021-04-01 12:06:17 -07:00
George Kalpakas
a95f579c84
ci: remove redundant entries from .pullapprove.yml ( #41250 )
...
This commit removes some entries from `.pullapprove.yml` that do not
correspond to existing files on disk.
PR Close #41250
2021-04-01 11:19:56 -07:00
Joey Perrott
5167030a3a
ci: remove *.bazel from dev-infra ownership ( #41382 )
...
Historically all .bazel files were owned by dev-infra to assist in ensuring that
consistency was maintained in how rules were being used. As this now has reached
a point of maturity in the repository where the check is mostly a rubber stamping,
this requirement can be removed. Notably this is different than the requirement
of dev-infra approval for .bzl files as these contain the implementation of macros
rather than just the usage.
PR Close #41382
2021-03-30 16:59:01 -07:00
Paul Gschwendtner
9f31cddfa6
ci: re-activate "devversion" in pullapprove after OOO ( #41352 )
...
After being OOO for a while, I have been denoted as OOO in the pullapprove
configuration (by commenting out the username in the reviewer lists).
See 3ba97ab391 .
This re-activates `devversion` in the pullapprove configuration.
PR Close #41352
2021-03-30 16:54:48 -07:00
Andrew Kushnir
6e942adc67
ci: remove Stephen from PullApprove config ( #41224 )
...
This commit updates PullApprove config and removes Stephen from the list of reviewers.
PR Close #41224
2021-03-16 11:00:33 -07:00
David Shevitz
cc75e1d17b
docs: add contributors guide to aio ( #41061 )
...
PR Close #41061
2021-03-15 12:16:37 -07:00
George Kalpakas
e3ea8630bc
ci: remove CHANGELOG.md from the public-api group ( #41135 )
...
This commit changes the owning group for the `CHANGELOG.md` file from
`public-api` to `dev-infra` (similar to other top-level `.md` files).
Internal discussion:
https://angular-team.slack.com/archives/C040TF8UT/p1615218082023400
PR Close #41135
2021-03-12 13:27:13 -08:00
David Shevitz
8658cd59b2
docs: add what is angular topic ( #40811 )
...
PR Close #40811
2021-02-17 11:13:21 -08:00
Pete Bacon Darwin
322951af49
refactor(compiler-cli): error on cyclic imports in partial compilation ( #40782 )
...
Our approach for handling cyclic imports results in code that is
not easy to tree-shake, so it is not suitable for publishing in a
library.
When compiling in partial compilation mode, we are targeting
such library publication, so we now create a fatal diagnostic
error instead of trying to handle the cyclic import situation.
Closes #40678
PR Close #40782
2021-02-17 06:53:38 -08:00
Joey Perrott
2d7bc1d301
ci: Remove language-service from testing group ( #40795 )
...
Much like the compiler-cli, the language-service package has internal testing
tools that are not intended for external use and do not need fw-testing review.
See #40679 .
PR Close #40795
2021-02-11 09:03:23 -08:00
Joey Perrott
68da05dc47
Revert "ci: Remove language-service from testing group ( #40787 )" ( #40794 )
...
This reverts commit 06671e85f9 .
PR Close #40794
2021-02-10 16:06:21 -08:00
Andrew Scott
06671e85f9
ci: Remove language-service from testing group ( #40787 )
...
Much like the compiler-cli, the language-service package has internal testing
tools that are not intended for external use and do not need fw-testing review.
See #40679 .
PR Close #40787
2021-02-10 16:00:31 -08:00
Jeremy Elbourn
5324a62ebe
docs: add guide for branching process ( #39924 )
...
PR Close #39924
2021-02-04 10:45:31 -08:00
Pete Bacon Darwin
2ba62e80fd
ci: add pete to the fw-http group ( #40619 )
...
This allows @petebacondarwin to approve PRs for the
`@angular/common/http` package.
PR Close #40619
2021-01-28 15:54:52 -08:00
hafiz
5a8e9394df
Remove myself from language-service reviews ( #40509 )
...
I am no longer actively working on the language service.
PR Close #40509
2021-01-21 13:50:52 -08:00
twerske
fbfd4889a9
build(docs-infra): error guides in docs ( #40060 )
...
add /errors to docs
create formatting for error guides infra
PR Close #40060
2021-01-14 11:28:52 -08:00
mgechev
25788106e5
ci: add mgechev to docs-marketing approvers ( #40396 )
...
Add mgechev to docs-marketing approvals to allow approval of aio changes
PR Close #40396
2021-01-13 14:03:34 -08:00
Andrew Kushnir
1e46b73463
ci: add new group to approve contributor list changes ( #40368 )
...
This commit adds a new `docs-contributors` group (with Emma and Minko as members) which will be used as reviewers
for PRs that update the list of contributors.
PR Close #40368
2021-01-11 09:48:48 -08:00
Joey Perrott
1437f4cf3c
build: use reviewed_for: ignored for required-minimum-review group ( #40338 )
...
Since all PRs will need to have this review, all reviews should apply
to this group even if someone is reviewing for another group.
PR Close #40338
2021-01-07 13:07:16 -08:00
Jessica Janiuk
d5a7a268cf
ci: add jessicajaniuk to pullapprove groups ( #40176 )
...
This adds jessicajaniuk to size-tracking, public-api, and circular-dependencies.
PR Close #40176
2021-01-06 07:04:07 -08:00
Joey Perrott
b473bc226c
ci: remove autolabeling from pullapprove config ( #40314 )
...
Remove the autolabeling configuration from the pullapprove config as it conflicts
too often with other tooling.
PR Close #40314
2021-01-05 12:30:42 -08:00
Jessica Janiuk
3e68b79106
Revert "Revert "ci: update pullapprove config to add comp labels"" ( #40059 )
...
This reverts commit c88e8141ab .
This reverts the revert that undid the doing of the pull approve
approval.
PR Close #40059
2020-12-10 13:51:09 -08:00
Jessica Janiuk
d39d64c15d
Revert "ci: update pullapprove config to add comp labels" ( #40053 )
...
This reverts commit 9f8ccd577f . The
PullApprove labeling is unfortunately removing labels rather than
adding them.
PR Close #40053
2020-12-09 12:06:26 -08:00
Jessica Janiuk
e39f923ff9
ci: update pullapprove config to add comp labels ( #39962 )
...
This adds comp labels to each group defined in the yml file.
PR Close #39962
2020-12-09 09:05:46 -08:00
Andrew Scott
55c21fadc8
ci: add atscott to language-service approvers ( #40027 )
...
Add myself (atscott) to the list of approvers for language-service PRs.
PR Close #40027
2020-12-08 12:09:23 -08:00
Joey Perrott
cc509d609f
build: update to husky@5 ( #39739 )
...
Update to husky version 5.0.0 to better support windows usage.
PR Close #39739
2020-11-18 11:11:41 -08:00
Kapunahele Wong
25d6fcacc4
docs: add doc with list of example apps currently in aio ( #39295 )
...
PR Close #39295
2020-11-13 11:34:43 -08:00
David Shevitz
f405aa51d7
docs: add update information for v11 release ( #39607 )
...
PR Close #39607
2020-11-09 12:20:34 -08:00
Joey Perrott
db1c48ff36
ci: only check testing directories within packages/ for fw-testing ( #39536 )
...
The fw-testing group should only match on testing directories within the
framework packages, previously it was also matching in other areas of
the codebase.
PR Close #39536
2020-11-02 16:39:44 -08:00
Jessica Janiuk
6d51ae2571
docs(core): add jessicajaniuk to pullapprove list ( #39473 )
...
This just adds jessicajessica to the pullapprove.yml file
PR Close #39473
2020-10-28 11:14:49 -07:00
Joey Perrott
50658d8796
ci: allow for disabling PullApprove on a single PR via adding a label ( #39430 )
...
Alowing for disabling PullApprove on a single PR via adding a label allows
for an escape hatch if PullApprove is not acting as expected, or for cases
where reviews can be stepped over in obvious situations, such as a revert.
PR Close #39430
2020-10-28 10:59:09 -07:00
Alan Agius
02b2d4b8ed
ci: add alan-agius4 to docs-cli in pullapprove configuration ( #39448 )
...
Add alan-agius4 to `docs-cli` group in pullapprove configuration.
PR Close #39448
2020-10-27 10:49:08 -07:00
Kapunahele Wong
177d76533d
docs: edit event-binding doc copy and headers ( #38903 )
...
PR Close #38903
2020-10-27 10:37:30 -07:00
Kapunahele Wong
3e6f24edcd
docs: edit property binding doc ( #38799 )
...
This commit edits the property binding doc copy and adds some
docregions to clarify explanations.
PR Close #38799
2020-10-21 08:23:42 -07:00
Dave Shevitz
a67895cee3
docs: Add Component Overview topic to angular.io ( #39186 )
...
PR Close #39186
2020-10-20 10:47:44 -07:00