skills/angular__angular
1
0
Fork 0
mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00
Code Issues Packages Projects Releases Wiki Activity
27,506 Commits 107 Branches 1,322 Tags
styling-experiments
Commit Graph

6546 Commits

Author SHA1 Message Date
piyush132000 b4ab710990 docs: removed empty method (#48236) 
I removed empty methods from a file and unnecessary import and added export keyword for exportng module

PR Close #48236
 2022-12-01 09:39:09 -08:00
Angular Robot b935255ef9 build: update all non-major dependencies (#48271) 
See associated pull request for more information.

PR Close #48271
 2022-11-30 09:29:26 -08:00
Angular Robot 208f52209b build: update eslint dependencies (#48216) 
See associated pull request for more information.

PR Close #48216
 2022-11-29 12:29:46 -08:00
Alan Agius 5f7f2d8673 build: remove codelyzer from aio dependencies (#48216) 
This package is no longer used.

PR Close #48216
 2022-11-29 12:29:46 -08:00
Alan Agius 612eaca3c5 build: update cross-repo dependencies to latest stable version (#48216) 
With this change we update the cross-repo dependencies to the latest stable version

PR Close #48216
 2022-11-29 12:29:46 -08:00
Derek Cormier 535838d67b build(bazel): fix aio deploy script (#48265) 
Move the copy of the bazel dist folder to the firebase dist folder
earlier on in the process so that any checks operate out of a single
folder.

PR Close #48265
 2022-11-29 20:04:24 +00:00
Bob Watson 2b55f4bf0d docs: update docs to use new build and test commands (#48266) 
PR Close #48266
 2022-11-28 15:33:53 -08:00
piyush132000 fcf857209f docs: removed empty methods (#48230) 
I removed empty methods from a file and unnecessary import

PR Close #48230
 2022-11-28 09:13:19 -08:00
Aristeidis Bampakos 379b2702d8 docs: update deployment to GitHub Pages (#48239) 
The GitHub Pages section has been moved to the left sidebar of the Settings page.
PR Close #48239
 2022-11-28 09:11:00 -08:00
Andrew Scott 228e992db7 docs(router): Deprecate canLoad guards in favor of canMatch (#48180) 
As mentioned in #46021, `canMatch` guards can replace `canLoad`. There
are slight differences between the two but the purpose of preventing
user access to feature modules is still achievable. There are several
reasons keeping `CanLoad` around is detrimental to the API surface:

* Lazy loading should not be an architectural feature of an application. It's an
optimization you do for code size. That is, there should not be an architectural
feature in the router to directly specifically control whether to lazy load something or
not based on conditions such as authentication. This slightly
different from the `canMatch` guard: the guard controls whether
you can use the route at all and as a side-effect, whether we download the code.
`CanLoad` only specified whether the code should be downloaded so `canMatch` is
more powerful and more appropriate.

* The naming of `CanLoad` will be potentially misunderstood for the `loadComponent` feature.
Because it applies to `loadChildren`, it feels reasonable to think that it will
also apply to `loadComponent`. This isn’t the case: since we don't need
to load the component until right before activation, we defer the
loading until all guards/resolvers have run.

* Unnecessary API surface bloat where two features (CanMatch and CanLoad) do
essentially the same thing. This affects code size for supporting two
nearly identical features as well as the learning and teaching journey
for them both.

* `CanLoad` guards have the downside of _only_ being run once to prevent
loading child routes. Once that passes and children are loaded, the
guard never runs again. As a result, developers need to always provide
_both_ canLoad and a canActivate in case the answer to the guard flips
back to `false`. This is not the case for `canMatch`, which will run
on every navigation.

DEPRECATED: CanLoad guards in the Router are deprecated. Use CanMatch
instead.

PR Close #48180
 2022-11-28 09:04:08 -08:00
Derek Cormier 12db492233 build(bazel): fix pwa test metrics 
Prior to the AIO bazel migration, the pwa test script only tested the
pwa metric. A bug was introduced where the score target was used for all
metrics, causing the AIO deploy test to fail.
 2022-11-23 14:57:32 -07:00
Derek Cormier b258b32f55 build(bazel): copy dist folder to aio for firebase deployment 
Firebase requires the distributable to be in the same folder as
firebase.json.
 2022-11-23 14:43:08 -07:00
Derek Cormier e864254224 build(bazel): point to correct dist folder in firebase config (#48211) 
Point to the AIO dist folder in the Bazel output tree.

PR Close #48211
 2022-11-23 12:12:29 -08:00
Derek Cormier 2e38af1f48 build(bazel): fix aio deployment unit tests 
Missing a spy for the new chmod call.
 2022-11-23 12:39:23 -07:00
Derek Cormier 776882ae7e build(bazel): remove write protection on aio dist folder for deployment 
Deploy script adds extra files and needs write access.
 2022-11-23 12:09:51 -07:00
Angular Robot a5c4e3d578 build: update bazel setup to v5.7.1 (#47884) 
See associated pull request for more information.

PR Close #47884
 2022-11-23 10:53:00 -08:00
Derek Cormier 6360e38d07 build(bazel): fix AIO deployment unit tests (#48206) 
Forgot to update the dist path in these tests.

PR Close #48206
 2022-11-23 18:30:44 +00:00
Derek Cormier 10f1e0fb3f build(bazel): fix dist dir in AIO deploy script (#48203) 
The script is run cd'ed into aio so the path to the Bazel dist
location is up one folder.

PR Close #48203
 2022-11-23 17:40:25 +00:00
Alan Agius 76e861f8de build: update safevalues to 0.4.2 (#48153) 
This contains a fix which enabled the ESM version of the package to be consumed.

See: https://github.com/angular/angular/issues/48171#issuecomment-1324728758

PR Close #48153
 2022-11-23 09:35:41 -08:00
Bob Watson cc472191a9 docs: update AIO code to v15 (#48153) 
PR Close #48153
 2022-11-23 09:35:41 -08:00
Derek Cormier 6948f0f0f3 build(bazel): fix AIO deployment script (#48188) 
Don't run the script under Bazel, except for the tests. Configure a
Bazel flag to select the AIO build configuration.

PR Close #48188
 2022-11-23 14:00:03 +00:00
Brooke 2009b57888 docs: add brooke avery to GDE resources (#47923) 
PR Close #47923
 2022-11-22 16:22:06 -08:00
Derek Cormier 28079b9364 build(bazel): fix yarn call in aio deploy script (#48185) 
Incorrectly calls yarn scripts from the root package.

PR Close #48185
 2022-11-22 22:53:30 +00:00
Joey Perrott 303bb4d27c build: reformat BUILD files (#48181) 
Reformat BUILD file usage of globs.

PR Close #48181
 2022-11-22 21:22:34 +00:00
Derek Cormier 903917b13d build(bazel): remaining AIO Bazel migration fixes 2022-11-22 13:51:16 -07:00
Derek Cormier a81d6d5da0 build(bazel): add missing dependency to deploy script 
Cannot load the root package.json. Surfaced after trying to merge
aio-bazel-migration to main because the deployment short circuits
on ci for feature branhces.
 2022-11-22 13:51:16 -07:00
Derek Cormier 7beee3ab83 build(bazel): mark a couple of aio example tests as flaky 
May be caused by resource contention when running the example tests in
parallel.
 2022-11-22 13:51:16 -07:00
Derek Cormier 2e823d3fb8 build(bazel): tweak parallel jobs for AIO local deps ci 
Parallel runs of tests on circleci executor push RAM to the limits.
 2022-11-22 13:51:16 -07:00
Derek Cormier 4c9f5b7c5e build(bazel): fix a regression when linking local packages for AIO example 
tests

Caused by code moving around.
 2022-11-22 13:51:16 -07:00
Derek Cormier 6cc3256018 build(bazel): fix linking of local angular packages 
Npm angular deps were transitively being included, confusing the
rules_nodejs linker.
 2022-11-22 13:51:16 -07:00
Derek Cormier 60058d2882 build(bazel): support ibazel for AIO example playgrounds 
Also uses more fine-grained deps to make an ibazel rebuild fast.
 2022-11-22 13:51:16 -07:00
Derek Cormier 837b8091f0 build(bazel): fix a bug where local ngc couldn't be linked into AIO example tests 
The ngc entrypoint escapes the sandboxed example folder. Rather than
always symlinking local packages, copy the full package when there are
bin entries.
 2022-11-22 13:51:16 -07:00
Derek Cormier 320f521a8c build(bazel): fix regressions for docs-watch 
Some earlier refactoring prevented the watchr script from running in
the source tree. There was also a Windows issue where running architect
didn't preserve symlinks causing the app to not be served.
 2022-11-22 13:51:16 -07:00
Derek Cormier a079720de1 build(bazel): fix remote cache missses on Windows and OSX 
Caused by chromium debug logs in @angular/build-tooling.
 2022-11-22 13:51:16 -07:00
Derek Cormier 4247136226 build(bazel): fix a regression where github links were incorrectly 
written

Incorrectly prepended 'packages/' to docs that were under aio/content.
 2022-11-22 13:51:16 -07:00
Derek Cormier 478164a0a8 build(bazel): fix missing dgeni dependencies 
Fixes the 'Export has no declarations: unknown' warning and
unresolved type warnings.
 2022-11-22 13:51:16 -07:00
Derek Cormier a61397f2f8 build(bazel): consolidate windows chromium path workaround 
Add the hack to a central location so that it's easier to fix later.
 2022-11-22 13:51:16 -07:00
Derek Cormier de48b19c42 build(bazel): fix an AIO bug where symlinked assets were not loaded on 
Windows

Added "followSymlinks" blocks on the assets.
 2022-11-22 13:51:16 -07:00
Derek Cormier 837d2a7a45 build(bazel): remove unused AIO package.json scripts 
No longer needed after the migration
 2022-11-22 13:51:16 -07:00
Derek Cormier 92d18bbac0 build(bazel): use workspace status command for AIO version stamping 
Fixes a bug where the navigation map did not have the correct SHAs.
 2022-11-22 13:51:16 -07:00
Derek Cormier f37dd0fc96 build(bazel): create AIO example playgrounds for manual testing 
After the bazel migration, AIO examples are no longer fully formed in
the source tree.
 2022-11-22 13:51:16 -07:00
Derek Cormier e4b82cea26 build(bazel): clean up pathing in aio build tooling 
Make use of process.env.RUNFILES.
 2022-11-22 13:51:16 -07:00
Derek Cormier ffea372105 build(bazel): update documentation for docs authors 
Where possible, preseve the original yarn commands.
 2022-11-22 13:51:16 -07:00
Derek Cormier c777fa7e22 build(bazel): fix a11y and pwa tests on Windows 
Needed to use absoulte paths and fix a separator.
 2022-11-22 13:51:16 -07:00
Derek Cormier cd1a90974a build(bazel): fix broken aio github links on Windows 
Caused the aio e2e tests to fail.
 2022-11-22 13:51:16 -07:00
Derek Cormier 474671568e build(bazel): fix aio example systemjs tests for locally linked packages 
These required a preserveSymlinks hack similar to the CLI tests
 2022-11-22 13:51:16 -07:00
Derek Cormier b6d80fb564 build(bazel): fix a bug where the opensearch url coudln't be substituted 
The file was write protected in the bazel output tree.
 2022-11-22 13:51:16 -07:00
Derek Cormier 9d4211e52b build(bazel): fix aio payload test to work with bazel output 
Was pointing to legacy build dist folder.
 2022-11-22 13:51:16 -07:00
Derek Cormier 74d358b177 build(bazel): fix a bug where deps in aio local build were not included 
This was breaking the local deps build.
 2022-11-22 13:51:16 -07:00
Derek Cormier 7bcefdcc63 build(bazel): selectively enable network access for some aio targets 
By default network access is disabled for actions on ci.
 2022-11-22 13:51:16 -07:00