angular__angular

skills/angular__angular

Fork 0

mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00

Commit Graph

Author	SHA1	Message	Date
Kristiyan Kostadinov	7da459102d	refactor(compiler-cli): use semver for version parsing (#54429 ) Follow-up to #54423 which uses `semver` to parse the version instead of doing it ourselves. PR Close #54429	2024-02-27 15:24:23 -08:00
Kristiyan Kostadinov	981c28c15f	refactor(compiler-cli): do not emit signal unwrap calls in versions older than 17.2 (#54423 ) In order to allow both signals and non-signals in two-way bindings, we have to pass the expression through `ɵunwrapWritableSignal`. The problem is that the language service uses a bundled compiler that is fairly new, but it may be compiling an older version of Angular that doesn't expose `ɵunwrapWritableSignal` (see https://github.com/angular/vscode-ng-language-service/issues/2001). These changes add a `_angularCoreVersion` flag to the compiler which the language service can use to pass the parsed Angular version to the compiler which can then decide whether to emit the function. PR Close #54423	2024-02-13 15:53:42 -08:00
Kristiyan Kostadinov	6897b76399	refactor(compiler-cli): split input and model tests (#54387 ) Splits up the tests for `input()` and `model()` into separate files. PR Close #54387	2024-02-12 11:01:53 -08:00

Author

SHA1

Message

Date

Kristiyan Kostadinov

7da459102d

refactor(compiler-cli): use semver for version parsing (#54429 )

Follow-up to #54423 which uses `semver` to parse the version instead of doing it ourselves.

PR Close #54429

2024-02-27 15:24:23 -08:00

Kristiyan Kostadinov

981c28c15f

refactor(compiler-cli): do not emit signal unwrap calls in versions older than 17.2 (#54423 )

In order to allow both signals and non-signals in two-way bindings, we have to pass the expression through `ɵunwrapWritableSignal`. The problem is that the language service uses a bundled compiler that is fairly new, but it may be compiling an older version of Angular that doesn't expose `ɵunwrapWritableSignal` (see https://github.com/angular/vscode-ng-language-service/issues/2001).

These changes add a `_angularCoreVersion` flag to the compiler which the language service can use to pass the parsed Angular version to the compiler which can then decide whether to emit the function.

PR Close #54423

2024-02-13 15:53:42 -08:00

Kristiyan Kostadinov

6897b76399

refactor(compiler-cli): split input and model tests (#54387 )

Splits up the tests for `input()` and `model()` into separate files.

PR Close #54387

2024-02-12 11:01:53 -08:00

3 Commits