angular__angular

skills/angular__angular

Fork 0

mirror of https://github.com/angular/angular.git synced 2026-09-14 13:54:52 +08:00

Commit Graph

Author	SHA1	Message	Date
Kristiyan Kostadinov	2a1723c945	test(compiler): fix broken integrity check (#51751 ) The `verifyPlaceholdersIntegrity` check in the compliance tests was basically a noop, because it was returning false inside a `forEach` callback. Fixing it revealed that it had fallen out of date, because one of the regexes it uses was incorrect. The problem is that it assumed the placeholder keys would always be string literals, however it's possible that they're identifiers. These changes resolve the issue by not looking at the keys at all since we don't do anything with them. PR Close #51751	2023-09-13 10:48:32 -07:00
Kristiyan Kostadinov	52cc7f839b	build: align with internal tsconfig options (#51728 ) Currently internally Angular has some customized tsconfig files, because we don't align with the tsconfig of the rest of g3. These changes enable `noImplicitReturns` and `noPropertyAccessFromIndexSignature` to align better with the internal config. PR Close #51728	2023-09-12 11:39:42 -07:00
Pete Bacon Darwin	2786292780	test(compiler-cli): migrate i18n compliance tests (#39661 ) This commit provides the machinery for the new file-based compliance test approach for i18n tests, and migrates the i18n tests to this new format. PR Close #39661	2020-11-25 11:08:39 -08:00

Author

SHA1

Message

Date

Kristiyan Kostadinov

2a1723c945

test(compiler): fix broken integrity check (#51751 )

The `verifyPlaceholdersIntegrity` check in the compliance tests was basically a noop, because it was returning false inside a `forEach` callback. Fixing it revealed that it had fallen out of date, because one of the regexes it uses was incorrect. The problem is that it assumed the placeholder keys would always be string literals, however it's possible that they're identifiers. These changes resolve the issue by not looking at the keys at all since we don't do anything with them.

PR Close #51751

2023-09-13 10:48:32 -07:00

Kristiyan Kostadinov

52cc7f839b

build: align with internal tsconfig options (#51728 )

Currently internally Angular has some customized tsconfig files, because we don't align with the tsconfig of the rest of g3. These changes enable `noImplicitReturns` and `noPropertyAccessFromIndexSignature` to align better with the internal config.

PR Close #51728

2023-09-12 11:39:42 -07:00

Pete Bacon Darwin

2786292780

test(compiler-cli): migrate i18n compliance tests (#39661 )

This commit provides the machinery for the new file-based compliance test
approach for i18n tests, and migrates the i18n tests to this new format.

PR Close #39661

2020-11-25 11:08:39 -08:00

3 Commits