4 Commits

Author SHA1 Message Date
Keen Yee Liau 95f748c238 fix(language-service): Add plugin option to force strictTemplates (#41063)
This commit adds a new configuration option, `forceStrictTemplates` to the
language service plugin to allow users to force enable `strictTemplates`.

This is needed so that the Angular extension can be used inside Google without
changing the underlying compiler options in the `ng_module` build rule.

PR Close #41063
2021-03-03 09:54:46 -08:00
Keen Yee Liau db28ed2341 refactor(language-service): add type guard for NgLanguageService (#40954) (#40968)
This is patch PR for #40954

Type guard should be colocated with the `NgLanguageService` interface,
not in `@angular/vscode-ng-language-service`.

PR Close #40954

PR Close #40968
2021-02-23 13:25:00 -08:00
Keen Yee Liau 6ba060fc5f refactor(language-service): Clean up getTcb interface (#40954) (#40968)
`GetTcbResponse` should not be a union type with `undefined`.

PR Close #40954

PR Close #40968
2021-02-23 13:25:00 -08:00
ayazhafiz ba6d8d44b1 refactor(language-service): pull out interfaces on package toplevel (#40773)
This is patch PR for #40621.

Two motivations behind this change:

1. We would like to expose the types of the Language Service to external
   users (like the VSCode extension) via the npm package, on the top
   level of the package
2. We would like the View Engine and Ivy LS to share a common interface
   (notably after the inclusion of `getTcb`, the Ivy LS upholds a
   strict superset of `ts.LanguageService`; previously both VE and Ivy
   LS were aligned on `ts.LanguageService`.)

To this end, this commit refactors the exports on the toplevel of the
`language-service/` package to just be types common to both the VE and
Ivy language services. The VE and Ivy build targets then import and use
these types accordingly, and the expectation is that an external user
will just import the relevant typings from the toplevel package without
diving into either the VE or Ivy sources.

Follow up on #40607

PR Close #40773
2021-02-10 10:37:58 -08:00