mirror of
https://github.com/adobe/skills.git
synced 2026-09-19 08:06:09 +08:00
Akanksha Jain
b9172cd9a9
* feat(aem-workflow): rewrite workflow-debugging skill for AEM Cloud Service - Add Audience, Variant Scope, and Dependencies sections - Correct cq.workflow.job.max.procs myth: property does not exist on WorkflowSessionFactory; real parallelism knob is queue.maxparallel on the Granite Workflow Queue (org.apache.sling.event.jobs.QueueConfiguration) - Fix lock contention guidance: reduce (not raise) queue.maxparallel - Replace vague stale handling with StaleWorkflowServlet pattern - Add concrete OSGi config file names and Git-based remediation paths - Add AEMaaCS platform caveats: DefaultThreadPool may be reserved, pod-restart requires Support ticket, IMS identity gotchas - Add Routing back to dev skills table - Update reference.md with JMX to CS translation table and diagnostic tools * Feat/skill workflow debugging cs review fixes (#150) * fix(aem-workflow): address review feedback and correct console URLs in workflow-debugging (Cloud Service) reference.md - Remove JMX to Cloud Service translation table; the skill should teach CS-correct instructions directly rather than reference and translate incorrect JMX-era content (review feedback) - Remove Bundled runbooks and Bundled supplementary docs sections; those references/* paths are not present in this skill folder - Drop Cloud Service note preamble describing on-the-fly JMX translation - Expand diagnostic tools table with Sling Thread Pools, Threads, jstack thread dump, Sling Scheduler, and OSGi Configuration entries - Replace broken overview-repoinit URL with overview#repoinit anchor - Switch javadoc link from 6.5 reference to AEMaaCS cloud-service javadoc - Add RejectedExecutionException and retrys-exceeded log patterns SKILL.md - Fix Sling Jobs page path: /system/console/slingjobs returns 404 on AEMaaCS; the actual page is /system/console/slingevent (page title is still "Jobs") - Fix Threads status path: /system/console/status-Threads is case sensitive; the lowercase variant returns 404 All console paths re-verified against the local AEMaaCS SDK. * fix(aem-workflow): expert audit pass against live AEM 6.5 LTS for workflow-debugging (#148) All claims re-validated against an OOTB AEM 6.5 LTS instance, Adobe's official Workflows Best Practices documentation, and Granite Workflow source on release/660 and prod/cq660. SKILL.md - Step 1: drop the dead 'Runbook' column; the runbook-*.md filenames it pointed at do not exist in the repo (the 'First action' column already carries the actionable command for each symptom) - Step 3a: the default Sling thread pool runs Quartz schedulers; it does not itself 'fire' com/adobe/granite/workflow/timeout/job — that is a Sling Job topic dispatched by a JobConsumer. Reword to reflect the scheduler -> Sling Job hand-off. Drop the bogus 'max pool size >= 20' healthy threshold: OOTB on AEM 6.5 LTS the default pool is 5/5 (Apache Sling default), with a note that hardened environments typically bump it to 20+ - Step 3d: the workflow timeout job is a Sling Job topic, not visible on /system/console/status-slingscheduler. Reword to point at /system/console/slingevent for the topic itself; only the periodic WorkflowStatsMBean Quartz job is visible on the scheduler page on OOTB 6.5 LTS - Step 5: drop the duplicated queue.maxparallel row that also wrongly said 'Default 1' (OOTB is 0.5). Correct the DefaultThreadPool max pool size default from 20 to 5. Add four useful WorkflowSessionFactory properties verified live and against source: inboxQuerySize, maxPurgeSaveThreshold, maxPurgeQueryCount, and the OOTB superuser group list. Add a Purge Scheduler row for the array-typed scheduledpurge.workflowStatus. Reframe cq.workflow.job.max.procs as an orphaned metatype label with no Java code path that reads it (verified against release/660 and prod/cq660 source — the property exists only in metatype.properties as an i18n UI label) and surface Adobe's documented recommended range of half-to-three-quarters of processor cores - Step 7: complete the Maintenance MBean signatures to match the live MBean — restartStaleWorkflows(model [optional], dryRun); retryFailedWorkItems(dryRun, model [optional]); terminateFailedInstances(restart, dryRun, model [optional]). Add the three useful per-model ops present on the live MBean but not documented: listRunningWorkflowsPerModel, listCompletedWorkflowsPerModel, returnFailedWorkflowCountPerModel - Step 8 Pattern A: replace 'All 20 threads consumed' with the accurate OOTB number (5), with the same hardening caveat. Clarify the block- policy behavior — OOTB is RUN, so the ABORT-driven silent drop only occurs in environments where the policy has been changed reference.md - Drop the 'Runbook locations (relative to repo root)' table; those aem-agent-marketplace-workflow-knowledge-base/runbooks/* paths are not bundled with this repo, so the table was a dead pointer - Drop the 'see also docs/error-patterns.md' hint for the same reason - Fix the broken /system/console/slingjobs entry (404 on AEM 6.5 LTS; the canonical Sling Jobs page is /system/console/slingevent) - Add four diagnostic-tool rows that are referenced from the SKILL.md but were not in this index: Sling Thread Pools, Threads, jstack thread dump, Sling Scheduler * fix(aem-workflow): expert audit pass and LTS parity for workflow-debugging (AEM Cloud Service) All claims re-validated against the local AEMaaCS SDK on localhost:4517, Adobe's Workflows Best Practices documentation, and Granite Workflow source on the master branch. Also brings CS skill coverage in line with the LTS audit landed in PR #148. Accuracy fixes - Step 3a: reword 'default pool fires com/adobe/granite/workflow/timeout/job' to reflect the actual hand-off — the default pool runs the periodic timeout-detection scheduler that emits the topic; the topic itself is consumed by a Sling JobConsumer. Replace the bogus 'max pool size >= 20' healthy threshold with the actual OOTB AEMaaCS SDK value of 10/10 (production environments may differ) - Step 3c: correct the Granite Workflow Queue Max Parallel default — on the AEMaaCS SDK the live OOTB value is queue.maxparallel = 0.5 (not 1 as previously stated). Add Adobe's documented recommended range of half to three-quarters of processor cores. Name the /system/console/slingevent URL explicitly (parity with LTS) - Step 3d: the workflow timeout job is a Sling Job topic, not visible on /system/console/status-slingscheduler. Reword to point at /system/console/slingevent for the topic itself; only the periodic WorkflowStatsMBean Quartz job is visible on the scheduler page - Step 5: correct the DefaultThreadPool maxPoolSize OOTB from 20 to 10 (verified live on the AEMaaCS SDK; production environments may differ). Reframe cq.workflow.job.max.procs as an orphaned metatype label with no Java code path that reads it (verified against AEM source on master — same orphan exists across release/660, prod/cq660 and master). Surface Adobe's recommended range of half to three-quarters of processor cores - Step 6: same reframing for the increase-parallelism cell. Correct the verification fallback value from 'usually 1' to '0.5 on the AEMaaCS SDK'. Fix the Fix auto-advancement row to point at the Sling Jobs page (not Sling Scheduler) for the timeout job topic - Step 7 Pattern A: replace 'All 20 threads consumed' with the accurate OOTB AEMaaCS SDK value (10). Clarify block-policy behavior — OOTB is RUN, so the ABORT-driven silent drop only occurs in environments where the policy has been changed LTS parity (coverage gaps closed) - Step 1: drop the dead 'Runbook' column; the runbook-*.md filenames point to files that do not exist in this skill folder (same fix as LTS PR #148). Rename heading to 'Map symptom to first action' - Step 5: add three useful WorkflowSessionFactory properties documented in the LTS skill and verified live on the CS SDK with the same OOTB values — granite.workflow.inboxQuerySize (2000), granite.workflow.maxPurgeSaveThreshold (20), and granite.workflow.maxPurgeQueryCount (1000)